[PATCH] D44790: [clang-format] Fix ObjC style guesser to also iterate over child lines
Ben Hamilton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 23 07:14:50 PDT 2018
benhamilton added inline comments.
================
Comment at: cfe/trunk/lib/Format/Format.cpp:1544
+ return true;
+ for (auto ChildLine : Line->Children) {
+ if (LineContainsObjCCode(*ChildLine))
----------------
djasper wrote:
> Sorry that I missed this in the original review. But doesn't this still fail for Children of Child lines, etc.? I think this probably needs to be fully recursive.
Oh, of course. I'll send a follow-up.
Repository:
rL LLVM
https://reviews.llvm.org/D44790
More information about the cfe-commits
mailing list