[PATCH] D33440: clang-format: better handle statement macros

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: lib/Format/Format.cpp:647-648
   LLVMStyle.SortUsingDeclarations = true;
+  LLVMStyle.StatementMacros.push_back("Q_UNUSED");
+  LLVMStyle.StatementMacros.push_back("QT_REQUIRE_VERSION");
 
----------------
What's the reason to have these in the LLVM style? The macros aren't used in LLVM code.


================
Comment at: unittests/Format/FormatTest.cpp:2424
+
+  // Some macros contain an implicit semicolon
+  FormatStyle Style = getLLVMStyle();
----------------
nit: Add a trailing period.


https://reviews.llvm.org/D33440