[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

[Stephen Hines via Phabricator via cfe-commits]

srhines added a comment.

Peter also requested that a test be added to make sure that rY was not accepted by the Clang assembler as a true synonym for xY.



================
Comment at: lib/Basic/Targets/AArch64.cpp:320
+    {{"r24"}, "x24"}, {{"r25"}, "x25"}, {{"r26"}, "x26"}, {{"r27"}, "x27"},
+    {{"r28"}, "x28"}, {{"r29"}, "fp"},  {{"r30"}, "lr"},
     // The S/D/Q and W/X registers overlap, but aren't really aliases; we
----------------
For x29, x30, you should really be grouping them together. For instance:

{{"r29", "fp"}, "x29}, {{"r30", "lr"}, "x30"}

This lets you remove the x29/fp and x30/lr from the first line.


Repository:
  rC Clang

https://reviews.llvm.org/D44815