[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 22 20:47:46 PDT 2018


dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

I agree with Saleem and Bob: `__is_target_*` is not confusing here and seems to be a straightforward spelling.  It has also already shipped in LLVM 6.0.0: it would be awkward to stop supporting this syntax.

Regardless, it's not clear that this patch is the right direction (i.e., we're not discussing the patch at all right now).  I suggest moving the discussion back to the wider audience on cfe-dev until we have consensus for a change.


Repository:
  rC Clang

https://reviews.llvm.org/D44753





More information about the cfe-commits mailing list