[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 22 10:15:16 PDT 2018


Quuxplusone added a comment.

@rtrieu gentle ping!

Action items I need help with, cut-and-pasted from above:

- Ideally, test compiling a bunch of (e.g. Google) code with https://reviews.llvm.org/D43322, see if there are any rough edges
- Decide if `-Wmove` should imply `-Wreturn-std-move` (I have preemptively done this)
- Review and land https://reviews.llvm.org/D43322
- Ideally, some discussion of whether I should write a paper for San Diego proposing that C++ //should// move rather than copy in these cases (my default plan is to do this)


Repository:
  rC Clang

https://reviews.llvm.org/D43322





More information about the cfe-commits mailing list