[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 21 14:34:30 PDT 2018


steven_wu added a comment.

I disagree. I think "target" is the correct name, even for cross compiling. For something compiled with -target foo, we are consistent calling it "target" during compile time. It only becomes appropriate to call it "host" during the runtime of the executable. There is no such concept as "host" when you are doing cross compiling.

The builtin macros are compile time constant, so following the compile time naming is much better.


Repository:
  rC Clang

https://reviews.llvm.org/D44753





More information about the cfe-commits mailing list