[PATCH] D40218: [Clang] Add __builtin_launder

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 21 13:47:25 PDT 2018


EricWF marked 2 inline comments as done.
EricWF added inline comments.


================
Comment at: test/CodeGenCXX/builtin-launder.cpp:93-96
+/// The test cases in this namespace technically need to be laundered according
+/// to the language in the standard (ie they have const or reference subobjects)
+/// but LLVM doesn't currently optimize on these cases -- so Clang emits
+/// __builtin_launder as a nop.
----------------
rsmith wrote:
> I would note that this means adding optimizations for those cases later is an LTO ABI break. That's probably OK, but just something we're going to need to remember.
I added your note almost verbatim to the test case.


https://reviews.llvm.org/D40218





More information about the cfe-commits mailing list