[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 21 13:11:18 PDT 2018


yaxunl added a comment.

In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote:

> Is there a reason for this to be done as a special case in IRGen instead of just implicitly applying the calling convention in Sema?


The calling convention is not used in Sema, therefore it seems simpler to do it in codegen. I could try doing this in Sema too. Is there any advantage of doing this in Sema?

Thanks.


https://reviews.llvm.org/D44747





More information about the cfe-commits mailing list