[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

Alfred Zien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 20 12:34:51 PDT 2018


QF5690 added a comment.

In https://reviews.llvm.org/D44539#1041993, @benhamilton wrote:

> I wonder if this wouldn't be better as a clang-tidy check:
>
> https://github.com/llvm-mirror/clang-tools-extra/tree/master/clang-tidy/objc


Border between clang-tidy checks and compiler diagnostics is not entirely clear for me, but, as I understand, clang-tidy is more about codestyle and some internal team agreements. The check that I'm adding is intended to prevent crashes, and it is much better to catch such things in compile time.


Repository:
  rC Clang

https://reviews.llvm.org/D44539





More information about the cfe-commits mailing list