[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 20 11:06:25 PDT 2018


phosek updated this revision to Diff 139163.
phosek marked an inline comment as done.

Repository:
  rCXX libc++

https://reviews.llvm.org/D44671

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -327,13 +327,8 @@
   message(FATAL_ERROR "LIBCXX_BUILD_32_BITS=ON is not supported on this platform.")
 endif()
 
-# Check that this option is not enabled on Apple and emit a usage warning.
 if (LIBCXX_ENABLE_STATIC_ABI_LIBRARY)
-  if (APPLE)
-    message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is not supported on OS X")
-  else()
-    message(WARNING "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option")
-  endif()
+  message(WARNING "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option")
   if (LIBCXX_ENABLE_STATIC AND NOT PYTHONINTERP_FOUND)
     message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY requires python but it was not found.")
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44671.139163.patch
Type: text/x-patch
Size: 832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180320/032cd970/attachment.bin>


More information about the cfe-commits mailing list