[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

Dustin L. Howett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 20 10:29:47 PDT 2018


DHowett-MSFT added inline comments.


================
Comment at: test/Sema/ms-forceinline-on-variadic.cpp:1
+// RUN: %clang_cc1 -emit-llvm -o - -triple i686-windows -verify -fms-extensions %s \
+// RUN:            | FileCheck %s
----------------
compnerd wrote:
> Personally, I prefer the fully canonicalized triple name `i686-unknown-windows-msvc`.
I'll do this.


================
Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14
+    __builtin_va_end(ap);
+}
+
----------------
compnerd wrote:
> Would be nice to have a second test that uses the Microsoft definitions (`char *` and the offsetting handling for the `va_list` since when building against the Windows SDK, that is the way that `va_list` and the `va_*` family of functions will get handled.
Should/do those still result in the intrinsic being emitted? If not, LLVM shouldn't have trouble during instruction scheduling, but inlining may still be broken. Regardless, though, this test exists only to make sure the function doesn't end up truly inlined, regardless of its contents.


Repository:
  rC Clang

https://reviews.llvm.org/D44646





More information about the cfe-commits mailing list