[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 20 10:22:27 PDT 2018


lebedev.ri updated this revision to Diff 139154.
lebedev.ri marked 5 inline comments as done.
lebedev.ri added a comment.

Address @aaron.ballman's review notes.

I'm not sure the change re `ParmVarDecl` handling is actually correct, see testcase.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44602

Files:
  clang-tidy/readability/FunctionSizeCheck.cpp
  clang-tidy/readability/FunctionSizeCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/readability-function-size.rst
  test/clang-tidy/readability-function-size-variables-c++17.cpp
  test/clang-tidy/readability-function-size.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44602.139154.patch
Type: text/x-patch
Size: 13406 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180320/3e9f9c97/attachment-0001.bin>


More information about the cfe-commits mailing list