[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 19 20:57:32 PDT 2018


phosek created this revision.
phosek added reviewers: EricWF, mclow.lists, compnerd, beanz.
Herald added subscribers: cfe-commits, christof, mgorny.

This seems to be working without any problems.


Repository:
  rCXX libc++

https://reviews.llvm.org/D44671

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -329,11 +329,7 @@
 
 # Check that this option is not enabled on Apple and emit a usage warning.
 if (LIBCXX_ENABLE_STATIC_ABI_LIBRARY)
-  if (APPLE)
-    message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is not supported on OS X")
-  else()
-    message(WARNING "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option")
-  endif()
+  message(WARNING "LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option")
   if (LIBCXX_ENABLE_STATIC AND NOT PYTHONINTERP_FOUND)
     message(FATAL_ERROR "LIBCXX_ENABLE_STATIC_ABI_LIBRARY requires python but it was not found.")
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44671.139071.patch
Type: text/x-patch
Size: 738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180320/6cee8766/attachment.bin>


More information about the cfe-commits mailing list