[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

[Henry Wong via Phabricator via cfe-commits]

MTC added a comment.

In https://reviews.llvm.org/D44557#1042357, @NoQ wrote:

> Sorry, one moment, i'm seeing a few regressions after the previous refactoring but i didn't look at them closely yet to provide a reproducer. I'll get back to this.


Thank you for the code review, @NoQ !

The regression is maybe caused by https://reviews.llvm.org/D44075, my patch! `CheckBufferAccess()` may not guarantee `checkNonNull()` will be called. If that's true, please revert https://reviews.llvm.org/rC326782 and I'll fix it.


Repository:
  rC Clang

https://reviews.llvm.org/D44557