[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 16 15:58:06 PDT 2018
vsapsai added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217
+ } else {
+ FixIts.push_back(FixItHint::CreateInsertion(
+ SelectorLocs[I], SelectorSlotNames[I]));
+ }
+ }
+ } else {
+ FixIts.push_back(FixItHint::CreateReplacement(UseRange, Replacement));
----------------
aaron.ballman wrote:
> You can elide a lot of braces here.
Just to clarify, is it OK if if-branch is with braces but else-branch without? I.e.
```
if (...) {
line 1
line 2
} else
the only line
```
https://reviews.llvm.org/D44589
More information about the cfe-commits
mailing list