[PATCH] D44561: [ARM] Add HasFloat16 to TargetInfo

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added a comment.

Thanks for the review. Please see a first comment inline.



================
Comment at: include/clang/Basic/TargetInfo.h:365
 
+  /// \brief Determine whether _Float16 is supported on this target.
+  virtual bool hasFloat16Type() const { return HasFloat16; }
----------------
t.p.northover wrote:
> `_Float16` doesn't seem to be supported anywhere in Clang (`__fp16` is).
> 
> But we should probably clarify exactly what kind of support we mean here. This variable doesn't affect:
> 
>   * Whether __fp16 can be used at all in source.
>   * Its ABI.
> 
> I'm actually slightly worried that when we document what it does affect it'll end up being an ARM implementation-detail.
> 
> 
I've added _Float16 support in Clang commit r312794: "Add _Float16 as a C/C++ source language type" :-)


https://reviews.llvm.org/D44561