[PATCH] D41217: [Concepts] Concept Specialization Expressions

Saar Raz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 11:23:08 PDT 2018


saar.raz added inline comments.


================
Comment at: lib/AST/ExprCXX.cpp:1478
+  {
+    // We do not want error diagnostics escaping here.
+    Sema::SFINAETrap Trap(S);
----------------
faisalv wrote:
> Hubert: This needs a TODO: the idea is not to drop SFINAE errors, but to avoid instantiation that may trigger errors not in the immediate context of instantiation. The substitution needs to happen piecewise.
Could you elaborate/give an example where this handling is inappropriate?


Repository:
  rC Clang

https://reviews.llvm.org/D41217





More information about the cfe-commits mailing list