[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 14 11:16:14 PDT 2018


aaron.ballman added inline comments.


================
Comment at: clang-tidy/zircon/TemporaryObjectsCheck.cpp:51
+         "creating a temporary object of type %0 is prohibited")
+        << D->getConstructor()->getParent()->getQualifiedNameAsString();
+}
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > You can skip the call to `getQualifiedNameAsString()`; the diagnostics engine will handle it properly.
> This doesn't seem to be done?
Ah, I see why now. You should change to `%q0` (and drop the existing single quotes) and then get rid of `getQualifiedNameAsString()`.


https://reviews.llvm.org/D44346





More information about the cfe-commits mailing list