[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tidy/zircon/TemporaryObjectsCheck.cpp:51
+         "creating a temporary object of type %0 is prohibited")
+        << D->getConstructor()->getParent()->getQualifiedNameAsString();
+}
----------------
aaron.ballman wrote:
> You can skip the call to `getQualifiedNameAsString()`; the diagnostics engine will handle it properly.
This doesn't seem to be done?


================
Comment at: docs/clang-tidy/checks/zircon-temporary-objects.rst:36-37
+
+  class Derived : Foo {} // Derived is not explicitly disallowed
+  Derived();             // and so temporary construction is okay
+
----------------
Can you hoist this into the exposition as well? It seems sufficiently important to warrant calling out in something other than an example.


https://reviews.llvm.org/D44346