[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: test/clang-tidy/misc-suspicious-semicolon-fail.cpp:5
-// RUN: clang-tidy %s -checks="-*,misc-suspicious-semicolon,clang-diagnostic*" \
-// RUN:    -- -DWERROR -Wno-everything -Werror=unused-variable 2>&1 \
 // RUN:   | FileCheck %s -check-prefix=CHECK-WERROR \
----------------
This reminds me that we should also filter out all -W(no-)error.* compiler arguments, if we're to take full control of clang diagnostics and make them behave closer to native checks.


================
Comment at: test/clang-tidy/validate-check-names.cpp:2
 // Check names may only contain alphanumeric characters, '-', '_', and '.'.
-// RUN: clang-tidy -checks=* -list-checks | grep '^    ' | cut -b5- | not grep -v '^[a-zA-Z0-9_.\-]\+$'
+// RUN: clang-tidy -checks=*,-clang-diagnostic* -list-checks | grep '^    ' | cut -b5- | not grep -v '^[a-zA-Z0-9_.\-]\+$'
----------------
Which clang diagnostic names fail this test?


https://reviews.llvm.org/D38171