[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

[Simon Marchi via Phabricator via cfe-commits]

simark added a comment.

In https://reviews.llvm.org/D44408#1036846, @ilya-biryukov wrote:

> We shouldn't add `Contents` parameter to every method, it would defeat the purpose of caching ASTs and won't allow to properly manage lifetimes of the indexes.


Makes sense.

> The most tricky part is getting rid of `DraftMgr` in `forceReparse`. Here's a change that removes usages of it there: https://reviews.llvm.org/D44462`, it should be much easier to make it work when it lands.

I'll take a look, thanks!

> Any other reason why we need to add them?

No, just ignorance on my part.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44408