[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Mar 11 16:46:57 PDT 2018
Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:47
+ const CXXRecordDecl *ThisClass) {
+
+ assert(GrandParent != nullptr);
----------------
Please remove empty line.
================
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:116
+
+ if (IsParentOf(CastToType, ThisType)) {
+ return;
----------------
No need for brackets.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
More information about the cfe-commits
mailing list