[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

[Simon Marchi via Phabricator via cfe-commits]

simark marked 2 inline comments as done.
simark added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:79
 
+static llvm::cl::opt<bool> Verbose("verbose", llvm::cl::desc("Be more verbose"),
+                                   llvm::cl::init(false));
----------------
ilya-biryukov wrote:
> simark wrote:
> > ilya-biryukov wrote:
> > > Maybe just call it `-v`?
> > I would have like to add both "-v" and "-verbose", but it doesn't seem possible to have two flags for the same option.  "-v" it is then, it is quite standard.
> I would go with having just `-v` with no aliases.
> 
> But this should do the trick if you prefer to have `-verbose` as an option:
> ```
> llvm::cl::opt<bool> Verbose("v", llvm::cl::alias("verbose") , //....
> ```
Ah ok thanks for the info.  I'll leave it with just `-v` here, but knowing this could be handy in the future.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44226