[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.
John Baldwin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 5 14:52:04 PST 2018
bsdjhb marked 2 inline comments as done.
bsdjhb added a comment.
This version follows the suggestion I made earlier of treating 32-bit floating point registers as a "plain" register for O32 rather than a floating-point register. It seems to work for me though for O32 I've only tested with 32-bit floating point registers. If we stick with this approach for 32-bit floating point it might be simpler and/or more readable to make _floats[] an array of uint32_t for that case and just use different context sizes for the O32 with 32-bit fp vs O32 with 64-bit fp. This version works in my testing on FreeBSD for O32 with 32-bit FPR, N32, and N64.
Repository:
rUNW libunwind
https://reviews.llvm.org/D41968
More information about the cfe-commits
mailing list