[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

Ben Hamilton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 5 08:12:55 PST 2018


benhamilton added a comment.

Actually, looking more deeply, it's possible this is a bug in the Apple SDK:

  @interface NSBundle
  - (NSString *)localizedStringForKey:(NSString *)key value:(nullable NSString *)value table:(nullable NSString *)tableName __attribute__((format_arg(1)));
  @end

Since `format_arg(X)` is 1-based, and `value` is the format param here, I wonder if this shouldn't be `__attribute__((format_arg(2))`.


Repository:
  rL LLVM

https://reviews.llvm.org/D25820





More information about the cfe-commits mailing list