[PATCH] D43248: [Attr] Fix parameter indexing for attributes
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 2 09:34:13 PST 2018
aaron.ballman added a comment.
In https://reviews.llvm.org/D43248#1025495, @jdenny wrote:
> Aaron, thanks for the review. I've applied your suggestions and am ready to commit.
You're correct that we have a lot of freedom with the commit message, but the important piece is in describing what's changed and why (if it's not immediately obvious). Both commit messages look good to me.
https://reviews.llvm.org/D43248
More information about the cfe-commits
mailing list