[PATCH] D43953: clangformat-vs: Fix plugin not correctly loading in some cases

[François-Xavier Roure via Phabricator via cfe-commits]

fxroure-ubisoft created this revision.
fxroure-ubisoft added a reviewer: clang.
fxroure-ubisoft created this object with edit policy "Only User: fxroure-ubisoft (François-Xavier Roure)".
Herald added a subscriber: cfe-commits.

When installing the clang-format visual studio plugin <https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.ClangFormat#overview> sometimes it won't be loaded correctly (some users seem to have the same issue <https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.ClangFormat#review-details>) and we must do

  devenv.exe /updateconfiguration

in order to fix the installation (normally visual studio should automatically execute this command whenever you install a plugin).
This issue seems to come from the fact that the plugin manifest does not list a VsPackage as an asset.
After adding it to assets list (code change in this review) installation of the plugin was working and when uninstalling the plugin visual correctly ask to restart it (that was not the case before).


Repository:
  rC Clang

https://reviews.llvm.org/D43953

Files:
  tools/clang-format-vs/source.extension.vsixmanifest.in


Index: tools/clang-format-vs/source.extension.vsixmanifest.in
===================================================================
--- tools/clang-format-vs/source.extension.vsixmanifest.in
+++ tools/clang-format-vs/source.extension.vsixmanifest.in
@@ -16,4 +16,7 @@
   <Prerequisites>
     <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[11.0,)" DisplayName="Visual Studio core editor" />
   </Prerequisites>
+  <Assets>
+    <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%;PkgdefProjectOutputGroup|" />
+  </Assets>
 </PackageManifest>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43953.136545.patch
Type: text/x-patch
Size: 637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180301/619b736a/attachment.bin>