[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 1 06:25:50 PST 2018


Eugene.Zelenko added a comment.

In https://reviews.llvm.org/D43847#1023452, @hokein wrote:

> In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote:
>
> > I need a bit more context because I'm unfamiliar with `absl`. What is this module's intended use?
>
>
> As `absl` has been open-sourced (https://github.com/abseil/abseil-cpp), I think there will be more absl-related checks contributed from google or external contributors in the future, so it make sense to create a new module.
>
> @niko, could you please refine the code style of this patch to follow the LLVM code standard <https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly> (especially the variable name, should be camel case "VariableName")?


May be //abseil// is better name for module?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43847





More information about the cfe-commits mailing list