[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

[Francois Ferrand via Phabricator via cfe-commits]

Typz added a comment.

In https://reviews.llvm.org/D42787#1022081, @djasper wrote:

> But you *do* want extra indentation in the case of:
>
>   function(aaaaa, 
>            bbbbb +
>            cccccc);
>   
>
> I understand you argument, but I don't agree at the moment. As is (without getting more feedback from others that clang-format is behaving unexpected here), I do not want to move forward with this change.


Indeed, because as much as we want to keep things aligned (and avoid extra indentation), we want above all to make code "easier to read": we think keeping alignment is indeed helping, but that keeping the alignment when it adds confusion is not...
Now let's hear what others are thinking about this behavior.

(BTW, I imagine there is no point introducing an option for this specific, if this does not get accepted as default? It may be done as part of https://reviews.llvm.org/D32478 to minimize options, in the new mode which tries to align more strictly... But last time you looked at it you were not very enthousiastic about it either...)


Repository:
  rC Clang

https://reviews.llvm.org/D42787