[PATCH] D41102: Setup clang-doc frontend framework

[Julie Hockett via Phabricator via cfe-commits]

juliehockett added inline comments.


================
Comment at: clang-doc/BitcodeWriter.h:37
+  static constexpr unsigned SubblockIDSize = 4U;
+  static constexpr unsigned BoolSize = 1U;
+  static constexpr unsigned IntSize = 16U;
----------------
lebedev.ri wrote:
> Hmm, you build with asserts enabled, right?
> I tried testing this, and three tests fail with
> ```
> clang-doc: /build/llvm/include/llvm/Bitcode/BitstreamWriter.h:122: void llvm::BitstreamWriter::Emit(uint32_t, unsigned int): Assertion `(Val & ~(~0U >> (32-NumBits))) == 0 && "High bits set!"' failed.
> ```
> ```
> Failing Tests (3):
>     Clang Tools :: clang-doc/mapper-class-in-function.cpp
>     Clang Tools :: clang-doc/mapper-function.cpp
>     Clang Tools :: clang-doc/mapper-method.cpp
> 
>   Expected Passes    : 6
>   Unexpected Failures: 3
> ```
> At least one failure is because of `BoolSize`, so i'd suspect the assertion itself is wrong...
I do, and I've definitely seen that one triggered before but it's been because something was off in how the data was being outputted as I was shifting things around. That said, I'm not seeing it in my local build with this diff though -- I'll update it again just to make sure they're in sync.


https://reviews.llvm.org/D41102