[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

John Baldwin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 27 13:43:45 PST 2018


bsdjhb added a comment.

After thinking about this some more, I need to rework this a bit.  The choice of how to expose the floating point registers via getFloatingPointRegister / setFloatingPointRegister only affects consumers of the libunwind unw_get_fpreg/unw_set_fpreg.  I think a bigger factor is that we need to honor unwind rules in frames that describe the saved location of FP registers on the stack (which this patchset doesn't do).  I think that's fairly trivial for the case where an FP register is the same size as a GP register, and it probably argues for storing 32-bit FP registers as individual 'float' if that is how the unwind information is encoded.  I haven't yet looked to see what the implications would be for O32 MIPS with 64-bit FP registers.  It may be that I punt on that configuration for now.


https://reviews.llvm.org/D41968





More information about the cfe-commits mailing list