r326171 - [Driver] Fix codeview-column-info on macOS

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 26 22:04:23 PST 2018


Author: smeenai
Date: Mon Feb 26 22:04:23 2018
New Revision: 326171

URL: http://llvm.org/viewvc/llvm-project?rev=326171&view=rev
Log:
[Driver] Fix codeview-column-info on macOS

macOS home directory paths begin with /Users, and clang-cl interprets
the /U portion as a macro undefine rather than a path, causing test
failures on macOS. Use a -- to explicitly treat the input file as a path
and fix the test.

This effectively reverts r326168 and adds an alternative fix.

Modified:
    cfe/trunk/test/Driver/codeview-column-info.c

Modified: cfe/trunk/test/Driver/codeview-column-info.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/codeview-column-info.c?rev=326171&r1=326170&r2=326171&view=diff
==============================================================================
--- cfe/trunk/test/Driver/codeview-column-info.c (original)
+++ cfe/trunk/test/Driver/codeview-column-info.c Mon Feb 26 22:04:23 2018
@@ -1,4 +1,3 @@
-// REQUIRES: system-windows
 // Check that -dwarf-column-info does not get added to the cc1 line:
 // 1) When -gcodeview is present via the clang or clang++ driver
 // 2) When /Z7 is present via the cl driver.
@@ -7,7 +6,7 @@
 // RUN: FileCheck < %t1 %s
 // RUN: %clangxx -### --target=x86_64-windows-msvc -c -g -gcodeview %s 2> %t2
 // RUN: FileCheck < %t2 %s
-// RUN: %clang_cl -### --target=x86_64-windows-msvc /c /Z7 %s 2> %t2
+// RUN: %clang_cl -### --target=x86_64-windows-msvc /c /Z7 -- %s 2> %t2
 // RUN: FileCheck < %t2 %s
 
 // CHECK: "-cc1"




More information about the cfe-commits mailing list