[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 26 15:04:45 PST 2018


jdenny updated this revision to Diff 135982.
jdenny added a comment.

Aaron: Because the last two arguments for objc_bridge_related must be delimited with commas, this revision takes the view that they are not optional but are permitted to be the empty string.

The test suite behaves as expected.  Are there any untested attributes that might be broken by this patch?  Hopefully they can be addressed in a similar manner.


https://reviews.llvm.org/D43748

Files:
  include/clang/Basic/Attr.td
  lib/Parse/ParseDecl.cpp
  test/Sema/attr-print.c
  test/Sema/attr-print.cpp
  utils/TableGen/ClangAttrEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43748.135982.patch
Type: text/x-patch
Size: 9851 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180226/8a132b63/attachment.bin>


More information about the cfe-commits mailing list