[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

[Jeremy Demeule via Phabricator via cfe-commits]

jdemeule added inline comments.


================
Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160
+      CleannedReplacements = std::move(FormattedReplacements);
+      if (!CleannedReplacements)
+        llvm_unreachable("!CleannedReplacements");
+    } else {
----------------
aaron.ballman wrote:
> This smells like it should be an assert rather than an unreachable.
Is returning an empty string OK?
This should let the assertion on the test do the job.


================
Comment at: unittests/clang-tidy/ClangTidyTest.h:167
+    if (!Result) {
+      // FIXME: propogate the error.
+      llvm::consumeError(Result.takeError());
----------------
aaron.ballman wrote:
> Are you intending to implement this fixme in this patch?
I suggest to remove the copy/paste containing the fixme. Is-it OK?
Maybe with some hints I can suggest a fix for this later.


https://reviews.llvm.org/D43500