[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 26 12:48:12 PST 2018


lebedev.ri created this revision.
lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc.
lebedev.ri added a project: clang.

Noticed during review of https://reviews.llvm.org/D41102.

I'm not sure whether there are any principal reasons why it returns raw owning pointer,
or it is just a old code that was not updated post-C++11.

I'm not too sure what testing i should do, because `check-all` is not error clean here for some reason,
but it does not //appear// asif those failures are related to these changes.

This is clang part.
Clang-tools-extra part is in the next differential.


Repository:
  rC Clang

https://reviews.llvm.org/D43779

Files:
  docs/LibTooling.rst
  docs/RAVFrontendAction.rst
  include/clang/Tooling/Tooling.h
  lib/Tooling/Tooling.cpp
  tools/clang-refactor/ClangRefactor.cpp
  unittests/AST/EvaluateAsRValueTest.cpp
  unittests/CrossTU/CrossTranslationUnitTest.cpp
  unittests/Sema/CodeCompleteTest.cpp
  unittests/Sema/ExternalSemaSourceTest.cpp
  unittests/Tooling/CommentHandlerTest.cpp
  unittests/Tooling/ExecutionTest.cpp
  unittests/Tooling/RefactoringTest.cpp
  unittests/Tooling/TestVisitor.h
  unittests/Tooling/ToolingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43779.135955.patch
Type: text/x-patch
Size: 25772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180226/31342da8/attachment-0001.bin>


More information about the cfe-commits mailing list