[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 26 12:37:34 PST 2018


juliehockett updated this revision to Diff 135944.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.

After discussion, the goal of this checker slightly changed to target definitions in header files, rather than declarations. As a result, the check now adds the attribute to any definition (declaration or not) that appears in a header file.

Also updating tests.


https://reviews.llvm.org/D43392

Files:
  clang-tidy/fuchsia/AddVisibilityCheck.cpp
  clang-tidy/fuchsia/AddVisibilityCheck.h
  clang-tidy/fuchsia/CMakeLists.txt
  clang-tidy/fuchsia/FuchsiaTidyModule.cpp
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/fuchsia-add-visibility.rst
  docs/clang-tidy/checks/list.rst
  test/clang-tidy/fuchsia-add-visibility-pragma.hpp
  test/clang-tidy/fuchsia-add-visibility.cpp
  test/clang-tidy/fuchsia-add-visibility.hpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43392.135944.patch
Type: text/x-patch
Size: 13817 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180226/765246b0/attachment-0001.bin>


More information about the cfe-commits mailing list