[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 26 09:29:39 PST 2018
aaron.ballman added a comment.
In https://reviews.llvm.org/D43749#1019359, @jdenny wrote:
> In https://reviews.llvm.org/D43749#1018846, @aaron.ballman wrote:
>
> > Committed (with whitespace fix for the test case) in r326058, thanks for the patch!
>
>
> Sure. Thanks for committing.
>
> By the way the commit log you added isn't quite right. The issue isn't base 0 versus base 1. The issue is attribute argument index versus attribute argument value. See the test case for an example.
>
> I'm not suggesting we somehow change the commit log. I just want to be sure you see what I actually did here.
Oh, yeah, I did muck up that commit log message a bit. Sorry about that!
https://reviews.llvm.org/D43749
More information about the cfe-commits
mailing list