[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 25 12:02:47 PST 2018


jdenny added inline comments.


================
Comment at: test/Misc/ast-print-objectivec.m:52
 // CHECK: @class C1;
-// CHECK: struct __attribute__((objc_bridge_related(C1, , ))) S1;
+// CHECK: struct __attribute__((objc_bridge_related(C1))) S1;
----------------
aaron.ballman wrote:
> This fix is incorrect in this case -- the attribute doesn't parse without the extra commas.
> 
> https://godbolt.org/g/Ze69HD
Sorry, I should have researched that one.

It is straight-forward to make it treat an argument as provided based on its argument type.  Will look into it soon.


https://reviews.llvm.org/D43748





More information about the cfe-commits mailing list