[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

[Yan Zhang via Phabricator via cfe-commits]

Wizard added a comment.

In https://reviews.llvm.org/D43581#1018584, @stephanemoore wrote:

> In https://reviews.llvm.org/D43581#1018499, @aaron.ballman wrote:
>
> > This LGTM! Do you need someone to commit on your behalf?
>
>
> I would be happy to commit assuming that I am able to and can meet submission requirements.
>
> I see a "Submit" button in Phabricator that I assume will land the commit if I press it?
>
> I found some submission guidelines in the LLVM Developer Policy <http://llvm.org/docs/DeveloperPolicy.html>. Are there any other submission guidelines I should follow?
>
> I ran the LLVM and Clang regression tests (by running `make check-all` from my LLVM build directory) and I encountered a failure in "Bindings/Go/go.test":
>
>   ******************** TEST 'LLVM :: Bindings/Go/go.test' FAILED ********************
>   Script:
>   --
>   /Users/mog/projects/llvm-build/bin/llvm-go go=/usr/local/go/bin/go test llvm.org/llvm/bindings/go/llvm
>   --
>   Exit Code: 1
>  
>   Command Output (stdout):
>   --
>   FAIL	llvm.org/llvm/bindings/go/llvm [build failed]
>  
>   --
>   Command Output (stderr):
>   --
>   # llvm.org/llvm/bindings/go/llvm
>   In file included from /var/folders/qh/4y215hgd4zqg30v9q04czw58005k3k/T/lit_tmp_7sZYWR/gopath735545420/src/llvm.org/llvm/bindings/go/llvm/analysis.go:17:
>   In file included from /Users/mog/projects/llvm/include/llvm-c/Analysis.h:22:
>   In file included from /Users/mog/projects/llvm/include/llvm-c/Types.h:17:
>   /Users/mog/projects/llvm-build/include/llvm/Support/DataTypes.h:35:10: fatal error: 'math.h' file not found
>   #include <math.h>
>            ^~~~~~~~
>   1 error generated.
>  
>   --
>  
>   ********************
>
>
> I reran these tests on a clean checkout and I still encountered the failure so I presume that this failure is unrelated?
>
> I have also been trying to run the `test-suite` but I have been encountering Python exceptions while trying to run `lnt` 😕.
>
> If someone wants to submit on my behalf that works for me. If not, I can also continue trying to drive this myself (though verification of submission requirements would be helpful in that case).


You may wanna follow this http://llvm.org/docs/Phabricator.html#git-svn-and-arcanist to submit your changes. But as aaron.ballman@ mentioned, you may need someone who has acl to commit it for you. 
For the error you see it is likely because you only updated the tools/extra repo. Usually when we sync this repo, we will have to pull parent repos as well (i.e. clang repo and llvm repo).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43581