[PATCH] D43696: Reduce hash collisions for reference and pointer types

[Richard Trieu via Phabricator via cfe-commits]

rtrieu added inline comments.


================
Comment at: lib/AST/ODRHash.cpp:581
+  void VisitType(const Type *T) {
+    ID.AddInteger(T->getTypeClass());
+  }
----------------
rsmith wrote:
> This looks redundant, the above `Visit(const Type*)` function seems to already do this.
That's correct, VisitType is intended to be empty.  The TypeClass enum value is added in Visit so that it is the first value added to the data stream.


================
Comment at: lib/AST/ODRHash.cpp:590
+  void VisitReferenceType(const ReferenceType *T) {
+    AddQualType(T->getPointeeType());
+    VisitType(T);
----------------
Use T->getPointeeTypeAsWritten() here.


Repository:
  rC Clang

https://reviews.llvm.org/D43696