[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please run Clang-format and Clang-tidy modernize.



================
Comment at: clang-doc/generators/Generators.h:46
+public:
+  MDGenerator(std::unique_ptr<InfoSet> &IS, StringRef Root, StringRef Format) : Generator(IS, Root, Format) {};
+  virtual ~MDGenerator() {};
----------------
Please remove semicolon after constructor body. Please enable CLang's -Wextra-semi.


================
Comment at: clang-doc/generators/Generators.h:47
+  MDGenerator(std::unique_ptr<InfoSet> &IS, StringRef Root, StringRef Format) : Generator(IS, Root, Format) {};
+  virtual ~MDGenerator() {};
+  
----------------
Please use = default;


https://reviews.llvm.org/D43424