[PATCH] D43667: [clang-doc] Implement a YAML generator

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please run Clang-format and Clang-tidy modernize over new code.



================
Comment at: clang-doc/generators/Generators.h:29
+  Generator(std::unique_ptr<InfoSet> &IS, StringRef Root, StringRef Format)
+      : IS(IS), Root(Root), Format(Format){};
+  virtual ~Generator(){};
----------------
Unnecessary ; after constructor body. Please enable Clang's -Wextra-semi


================
Comment at: clang-doc/generators/Generators.h:30
+      : IS(IS), Root(Root), Format(Format){};
+  virtual ~Generator(){};
+
----------------
Please use = default;


================
Comment at: clang-doc/generators/Generators.h:47
+  YAMLGenerator(std::unique_ptr<InfoSet> &IS, StringRef Root, StringRef Format)
+      : Generator(IS, Root, Format){};
+  virtual ~YAMLGenerator(){};
----------------
Unnecessary ; after constructor body.


================
Comment at: clang-doc/generators/Generators.h:48
+      : Generator(IS, Root, Format){};
+  virtual ~YAMLGenerator(){};
+
----------------
Please use = default;


================
Comment at: test/clang-doc/namespace-yaml.cpp:11
+void f();
+void f() {};
+
----------------
Unnecessary ; after function body.


https://reviews.llvm.org/D43667