[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 23 06:21:22 PST 2018


sdardis added a subscriber: arichardson.
sdardis added a comment.

This works as expected with your corresponding libcxx patch. However @arichardson 's https://reviews.llvm.org/D42139 does similar things for libcxx. We should wait for that to land, and ensure that this patch is rebased against that.



================
Comment at: CMakeLists.txt:142
 set(LIBUNWIND_SYSROOT "" CACHE PATH "Sysroot for cross compiling.")
+set(LIBUNWIND_TEST_CFLAGS "" CACHE PATH "Additional compiler flags for test programs.")
 
----------------
PATH should be STRING.


================
Comment at: test/lit.site.cfg.in:25
 config.cxx_ext_threads          = "@LIBUNWIND_BUILD_EXTERNAL_THREAD_LIBRARY@"
+config.test_cflags              = "@LIBUNWIND_TEST_CFLAGS@"
 
----------------
This should be test_compiler_cflags.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D43585





More information about the cfe-commits mailing list