[PATCH] D43510: [clangd] don't insert new includes if either original header or canonical header is already included.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 23 05:59:23 PST 2018
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, and sorry for the delay!
================
Comment at: clangd/Headers.cpp:45
private:
- std::set<std::string> &Headers;
+ std::set<std::string> &WrittenHeaders;
+ std::set<std::string> &ResolvedHeaders;
----------------
nit: StringSet? std::set is pretty bad unless we need ordering
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43510
More information about the cfe-commits
mailing list