[PATCH] D43671: [clangd] Address FIXME and fix comment
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 23 03:59:41 PST 2018
omtcyfz marked an inline comment as done.
omtcyfz added inline comments.
================
Comment at: clangd/tool/ClangdMain.cpp:153
+ if (RunSynchronously) {
+ if (WorkerThreadsCount != 0) {
+ llvm::errs()
----------------
ioeric wrote:
> `-j` is non-zero by default, and we shouldn't show warning if users only specify `-run-synchronously`. We should only warn if user explicitly set worker count while also providing `-run-synchronously`.
Oh, you're correct, I should've been more careful. This should be fine now.
https://reviews.llvm.org/D43671
More information about the cfe-commits
mailing list