[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM with a minor nit.



================
Comment at: clangd/CodeComplete.cpp:705
   }
+  CI->getDiagnosticOpts().IgnoreWarnings = true;
   auto Clang = prepareCompilerInstance(
----------------
Could we add a comment that this should be done before calling `prepareCompilerInstance`?
I'm afraid this can be accidentally reordered when changing the code.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43569