[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added inline comments.


================
Comment at: include/math.h:1499
+// has previously been included.
+#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES)
+#include_next <math.h>
----------------
pcc wrote:
> Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part.
I proposed that deliberately.

With the test, if you don't define `_USE_MATH_DEFINES` and re-include `<math.h>` it does nothing; which is what you want.

The MS-supplied `<math.h>` probably does this already, but ...


https://reviews.llvm.org/D43579