[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 21 10:53:59 PST 2018


aaron.ballman added a comment.

In https://reviews.llvm.org/D43581#1014903, @stephanemoore wrote:

> In https://reviews.llvm.org/D43581#1014664, @aaron.ballman wrote:
>
> > LGTM with a few additional test cases.
> >
> > It'd be nice if the style guide linked actually described what a "good" prefix is rather than make the reader guess.
>
>
> I will work on updating the Google Objective-C style guide to provide more clarity regarding what constitutes an appropriate prefix.


Fantastic, thank you! This patch LGTM.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43581





More information about the cfe-commits mailing list