[PATCH] D42645: New simple Checker for mmap calls

[David CARLIER via Phabricator via cfe-commits]

devnexen added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until the state changes
----------------
emaste wrote:
> devnexen wrote:
> > emaste wrote:
> > > I'm a bit confused by this comment; this checker works as-is for most common operating system cases, correct?
> > Most of them yes, at least Muslc linux most of glibc I tested too. Not to mention *BSD ... But might be safer to put it as alpha for a start.
> OK - to me it implies that the checker only works (anywhere) if the user provides the flag values. Maybe something like "the defaults are correct for several common operating systems, but may need to be overridden ...."
Fair point, I ll rephrase a bit.


https://reviews.llvm.org/D42645