[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/index/FileIndex.cpp:18
 
-const CanonicalIncludes *canonicalIncludesForSystemHeaders() {
-  static const auto *Includes = [] {
----------------
ilya-biryukov wrote:
> Should we also remove the mutex from `CanonicalIncludes` now?
I am inclined to keeping it as it brings thread-safety to `CanonicalIncludes` (which we wouldn't need to worry about in the future), and the current users are not in performance critical code path anyway.


================
Comment at: clangd/index/SymbolCollector.cpp:172
+
+  auto U = toURI(SM, SM.getFilename(Loc), Opts);
+  if (!U)
----------------
ilya-biryukov wrote:
> Maybe simplify to `return toURI(...)`?
> Or is there a reason why it doesn't work?
No reason... #this is what happened when copy-paste code...


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43550